Migrate to OpenTelemetry

[mrsufgi]

Hey,

Very cool package, I'm planning to add it to my toolchain but unfortunately you only have openCensus ("deprecated"). Did you ever though about migrating to OpenTelemetry?

LMK, perhaps I can contribute a new tracer.

Best Ori

[eranharel]

Hi Ori,

I'm glad you find this library useful. While initially we implemented the metrics directly inside the code, we decided to extract it to a separate module github.com/AppsFlyer/go-sundheit/opencensus, and added listeners exactly for that reason. We wanted to allow you to add your own metrics implementation.

So at this point you're welcome to contribute your own OTEL module implementation for go-sundheit (and provide a PR we can merge), implement it internally for your company, or let me know whether you want us to do this (may take a while, as I need to shift priorities for this).

What do you think?

[sagikazarmark]

Keep in mind that submodules is usually better to avoid.

You can always create a separate package, link it in the readme, move it to this org, etc.

[eranharel]

We'll implement this support here: go-sundheit-opentelemetry

[sagikazarmark]

Any news? I can see there is a branch. Any plans to polish/release it?

[eranharel]

Holidays are over in 2 days ;)

I need to review this: https://github.com/AppsFlyer/go-sundheit-opentelemetry/pull/1 Will do it on Tuesday if I have time. You're welcome to take a look too @sagikazarmark