Applied-Energistics-2
Applied-Energistics-2 copied to clipboard
AppliedEnergistics
Optionally Use Search Engine from JEI or REI
Allows to use the Search Engine from JEI or REI.
This can be useful because it is annoying when you try to search something with the modid and the name like it is possible in JEI. For example "@ae2 crystal". Without it, it tries to search a mod with the name "ae2 crystal". It is configurable in the Terminal Settings. (opt-out to disable btw)
Thanks for this PR, this is an interesting feature. I'll need to take an in-depth look at this w.r.t. performance and behavior when JEI/REI are absent.
@MarkusTieger Sorry for not coming back to you earlier. I am in the process of moving master to Neoforge, so it'll take a while before I can get to this PR. I also would like to actually refactor the functionality significantly, namely that "use JEI search" (the BIG radio buttons we currently have) should probably use this functionality instead of just hiding our own search box, but then use different filter logic.
All in all: it will take a while 😓
@MarkusTieger Sorry for not coming back to you earlier. I am in the process of moving master to Neoforge, so it'll take a while before I can get to this PR. I also would like to actually refactor the functionality significantly, namely that "use JEI search" (the BIG radio buttons we currently have) should probably use this functionality instead of just hiding our own search box, but then use different filter logic.
All in all: it will take a while 😓
no problem
Any progress? We all very need this change! :)
I almost forgot this issue, thanks for reminding me. This week I am busy, but I should be able to update this pr in the next week.
We no longer support JEI in 1.20.6+ at the moment, so that is not going to work...
I guess this issue is no longer required and https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/7883 will resolve the issue with the bad search?