Applied-Energistics-2 icon indicating copy to clipboard operation
Applied-Energistics-2 copied to clipboard

port forge's chunkloading api, so the spatial anchor works

Open Mari023 opened this issue 1 year ago • 4 comments

  • [ ] the spatial anchor's overlay doesn't render correctly
  • [ ] I am not quite sure with the licensing, the classes copied from forge all have their license header, but I am not sure about the patches I converted into mixins (+ an interface for some of the mixins)

Mari023 avatar Sep 02 '22 13:09 Mari023

Oh niiiiiiiiiiiiiiiiiiiiice.

It's not going to work though, since portaforgy is not part of the published mod artifact 😩

I wouldn't worry about the Mixins since you did rewrite them.

I would have expected this to be more code overall 🤔

shartte avatar Sep 02 '22 14:09 shartte

I am not quite sure with the licensing, the classes copied from forge all have their license header, but I am not sure about the patches I converted into mixins (+ an interface for some of the mixins)

Forge patches are CC0, no worries.

Technici4n avatar Sep 02 '22 15:09 Technici4n

I tried to find this in the current license file but could not verify it. But on the other hand I find it difficult to believe they could claim copyright hook insertions into propietary code owned.by Microsoft...

Technici4n @.***> schrieb am Fr., 2. Sept. 2022, 17:06:

I am not quite sure with the licensing, the classes copied from forge all have their license header, but I am not sure about the patches I converted into mixins (+ an interface for some of the mixins)

Forge patches are CC0, no worries.

— Reply to this email directly, view it on GitHub https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/6527#issuecomment-1235611556, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJT6VZ7PPAZYZFHI2K4ZWDV4IJWJANCNFSM6AAAAAAQDJJSSQ . You are receiving this because you commented.Message ID: @.*** com>

shartte avatar Sep 02 '22 17:09 shartte

Hmmm, the Forge CLA says that Forge owns copyright over the patches and they are licensed under LGPL2.0 (wtf?).

image

Technici4n avatar Sep 02 '22 18:09 Technici4n