adapter icon indicating copy to clipboard operation
adapter copied to clipboard

Start to free mbufs/pages

Open rv32ima opened this issue 5 years ago • 3 comments

https://github.com/AppleIntelWifi/adapter/blob/d66ed5c4315371a56de4ce52e4f7318b2120b3e6/AppleIntelWifiAdapter/trans/IWLTransportRx.cpp#L1449-L1471

Investigate whether we can actually free these pages? If so, free and ensure that we're not leaking memory everywhere

rv32ima avatar Mar 21 '20 16:03 rv32ima

page_stolen means that we have token this page off and allocate another page to map instead, this stolen page we can use to "handle_rxb" function, after using it, we should free.

zxystd avatar Mar 25 '20 07:03 zxystd

Definitely free, but #4 needs to happen here too.. how do we tag the mbufs? Maybe within the metadata fields?

rv32ima avatar Mar 25 '20 20:03 rv32ima

How about using mbuf_tag_allocate? add a global tag id to mbuf which is allocate from allocatePacket.

zxystd avatar Mar 26 '20 01:03 zxystd