AppleCommander icon indicating copy to clipboard operation
AppleCommander copied to clipboard

Unexpected newline in about box sentence

Open ryandesign opened this issue 2 years ago • 0 comments

On macOS Monterey 12.6.8 the AppleCommander 1.8.0 about box looks like this:

about

Don't ask me why Apple decided to change dialog boxes to be vertical and use centered text starting in macOS 11. I think it looks ugly as crap but that's what we've got. Here's what it looks like on macOS Sierra 10.12.6:

about-10 12

The problem I'm reporting is that between the words "express" and "purpose" there is a hard newline, causing an unexpected break in the sentence:

https://github.com/AppleCommander/AppleCommander/blob/0bccdde28a5fe9084056ff79559604a29d61502d/lib/ac-api/src/main/resources/com/webcodepro/applecommander/ui/UiBundle.properties#L310

The UI is clearly doing its own word wrapping already, and just changing that newline to a space resolves it for me, though I don't know if that causes problems for other systems that present the about box differently.

about-fixed

about-10 12-fixed

--- lib/ac-api/src/main/resources/com/webcodepro/applecommander/ui/UiBundle.properties.orig	2022-05-23 14:21:51.000000000 -0500
+++ lib/ac-api/src/main/resources/com/webcodepro/applecommander/ui/UiBundle.properties	2023-10-22 22:34:31.000000000 -0500
@@ -307,7 +307,7 @@
 SwtAppleCommander.CompareDiskImageTooltip=Compare two disk images (Ctrl+E)
 SwtAppleCommander.AboutTooltip=About AppleCommander (Ctrl+A)
 SwtAppleCommander.AboutTitle=About AppleCommander
-SwtAppleCommander.AboutMessage=AppleCommander\nVersion {0}\n{1}\n\nAppleCommander was created for the express\npurpose of assisting those-who-remember.\n\nI wish you many hours of vintage pleasure\!\n-Rob
+SwtAppleCommander.AboutMessage=AppleCommander\nVersion {0}\n{1}\n\nAppleCommander was created for the express purpose of assisting those-who-remember.\n\nI wish you many hours of vintage pleasure\!\n-Rob
 SwtAppleCommander.UnexpectedErrorTitle=Application Error
 SwtAppleCommander.UnexpectedErrorMessage=Unfortunately "{0}" triggered an unexpected application error.\n\nPlease report this to the developers.\n\nWe are terribly sorry for the inconvenience\!
 SwtAppleCommander.DiskCorruptException.RecursiveDirectoryStructure.Title=Recursive Directory structure detected.

ryandesign avatar Oct 23 '23 03:10 ryandesign