appium-gestures-plugin icon indicating copy to clipboard operation
appium-gestures-plugin copied to clipboard

[Swipe] Can we make MAGIC_NUMBER a parameter?

Open agata-adamczewska-jt opened this issue 2 years ago • 2 comments

Hi, I found a problem with using swipe gesture in the app I test. When I want to swipe-up the start point is located on the bottom button and minimise the app instead of swiping it. It is because the scrollable element has a full screen height, there is no smaller scrollable element on this page so I can't change it. I found in the source code that there is a MAGIC_NUMBER which decides about the offset of the starting point from the element (in this case screen) edge. It is hardcoded to 49. If we could make it as a parameter, or at least decrease its value to 40, it would help me a lot. Do you think you could do this?

agata-adamczewska-jt avatar Jul 25 '23 16:07 agata-adamczewska-jt

Hi, I found a problem with using swipe gesture in the app I test. When I want to swipe-up the start point is located on the bottom button and minimise the app instead of swiping it. It is because the scrollable element has a full screen height, there is no smaller scrollable element on this page so I can't change it. I found in the source code that there is a MAGIC_NUMBER which decides about the offset of the starting point from the element (in this case screen) edge. It is hardcoded to 49. If we could make it as a parameter, or at least decrease its value to 40, it would help me a lot. Do you think you could do this?

yes, it will be good, if there is option to provide edge

dipakkumar1225 avatar Nov 07 '23 14:11 dipakkumar1225

We should definitely improve this to keep it more dynamic.

saikrishna321 avatar Nov 08 '23 02:11 saikrishna321