appium-device-farm icon indicating copy to clipboard operation
appium-device-farm copied to clipboard

Fix: session should not be forwarded for devices in the hub

Open afathonih opened this issue 1 year ago • 3 comments

  1. Fix regression bug when introducing nodeId in devices. Session for devices in the bug was forwarded to the hub. Forwarding should not happen for devices in the hub.
  2. Added test cases to cover the use case of forwarding. Introduce new pluginArg to help with testing: preventSessionForwarding
  3. Added clean-up step to remove devices on the node where nodeId is not the same.
  4. Sync removed device when nodeId change (when starting node).
  5. Fix issue caused by node-persist (removing it from the equation)

afathonih avatar Jan 17 '24 08:01 afathonih

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appium-device-farm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 4:57am

vercel[bot] avatar Jan 17 '24 08:01 vercel[bot]

Deploy Preview for voluble-wisp-b266e5 ready!

Name Link
Latest commit cc3facb37634cd75fff59d54374204945a88ae94
Latest deploy log https://app.netlify.com/sites/voluble-wisp-b266e5/deploys/65c1bbf29e1dca0008a2bc3a
Deploy Preview https://deploy-preview-968--voluble-wisp-b266e5.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 17 '24 08:01 netlify[bot]

@saikrishna321 @sudharsan-selvaraj anything else you want to change/test in this PR?

afathonih avatar Jan 26 '24 04:01 afathonih