Add JDK9 Module name

[benoitx]

Using method described in https://dzone.com/articles/automatic-module-name-calling-all-java-library-maintainers

[martindiphoorn]

Why is this stil open?

[benoitx]

Not sure? Is it done properly?

---

Important Notice This communication contains information that is considered confidential and may also be privileged. It is for the exclusive use of the intended recipient(s). If you are not the intended recipient(s) please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited and may be unlawful. If you have received this communication in error please return it to the sender and delete the original

On 22 Nov 2018, at 09:10, Martin Diphoorn [email protected] wrote:

Why is this stil open?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

[martindiphoorn]

We should probably also add a module-info.java

See below site for a tutorial: https://blog.codefx.org/java/java-module-system-tutorial/

[benoitx]

In middle of Brexit (multiple) deliveries right now...if you could handle it, it would be great.

Thanks

B

On Wed, 5 Dec 2018 at 08:47, Martin Diphoorn [email protected] wrote:

We should probably also add a module-info.java

See below site for a tutorial: https://blog.codefx.org/java/java-module-system-tutorial/

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Appendium/flatpack/issues/32#issuecomment-444405841, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPeaUX2Yw1vVm3QfTp6IKig7uM5oIIiks5u14gugaJpZM4RDPOd .

[martindiphoorn]

I did have a quicklook, but if i try to compile with java 11 i receive an error with osgi. And i don't have the time to look into that.

java.lang.NullPointerException
        at aQute.bnd.header.OSGiHeader.quote(OSGiHeader.java:150)

Also i don't know if i make it a java 11 module it will still work in osgi.

I think it would also be a good thing to cleanup our pom's a little bit. Make sure that the parent contains all the versions in properties. And the modules are using those. Now java version is defined in more then one place.

An other thing i don't know is this parent:

    <parent>
        <groupId>org.sonatype.oss</groupId>
        <artifactId>oss-parent</artifactId>
        <version>7</version>
    </parent>

And if it will be a problem with java 11.

[benoitx]

That parent Pom allows us to deploy on Maven Central.

Agreed, I’d like to re-.org all our poms for FlatPack, ObjectlabUtil, JTreeMap and nachocalendar....

Every release is painful 😖...

---

Important Notice This communication contains information that is considered confidential and may also be privileged. It is for the exclusive use of the intended recipient(s). If you are not the intended recipient(s) please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited and may be unlawful. If you have received this communication in error please return it to the sender and delete the original

On 6 Dec 2018, at 19:20, Martin Diphoorn [email protected] wrote:

I did have a quicklook, but if i try to compile with java 11 i receive an error with osgi. And i don't have the time to look into that.

java.lang.NullPointerException at aQute.bnd.header.OSGiHeader.quote(OSGiHeader.java:150) Also i don't know if i make it a java 11 module it will still work in osgi.

I think it would also be a good thing to cleanup our pom's a little bit. Make sure that the parent contains all the versions in properties. And the modules are using those. Now java version is defined in more then one place.

An other thing i don't know is this parent:

<parent>
    <groupId>org.sonatype.oss</groupId>
    <artifactId>oss-parent</artifactId>
    <version>7</version>
</parent>

And if it will be a problem with java 11.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.