appimage.github.io icon indicating copy to clipboard operation
appimage.github.io copied to clipboard

Add RMG

Open Rosalie241 opened this issue 2 years ago • 7 comments

I hope I did it correctly!

Rosalie241 avatar Feb 19 '23 15:02 Rosalie241

Hi @Rosalie241, thanks for posting.

If the AppImage was following the usual naming scheme RMG-0.3.6-x86_64.AppImage instead of RMG-Portable-Linux64.AppImage, then it would work by just pasting the https://github.com/Rosalie241/RMG URL.

Would you like to rename the AppImage, or would you like me to use it as-is?

probonopd avatar Feb 19 '23 20:02 probonopd

I'd like to keep it as-is for the moment, but shouldn't the script fallback to finding any AppImage? From a quick glance of the CI run I think it should so I'm rather confused as to why it isn't finding it.

Rosalie241 avatar Feb 19 '23 20:02 Rosalie241

Unfortunately, this was compiled on a too new system and hence cannot run on all still-supported LTS releases of Ubuntu:

/lib/x86_64-linux-gnu/libm.so.6: version 'GLIBC_2.29' not found (required by /run/firejail/appimage/.appimage-10214/usr/bin/RMG)

We cannot assume at this time that all users have GLIBC 2.29 already. It is still too new.

probonopd avatar Feb 19 '23 20:02 probonopd

It was built using CI on ubuntu 20.04, I didn't pick ubuntu 18.04 because that github actions image will be deprecated in about a month, so I picked the next LTS, ubuntu 20.04.

Rosalie241 avatar Feb 19 '23 21:02 Rosalie241

Let's revisit this in April then, when 18.04 will no longer be supported.

probonopd avatar Feb 19 '23 21:02 probonopd

Variable FILES is empty. seems to happen when someone else (not me) has created or edited a PR; probably some of my logic to figure out the last edited file is flawed? Maybe you can think of a better way to get to the file in question that worker.sh should operate on?

probonopd avatar Mar 12 '23 12:03 probonopd

After thinking and trying things, I'm not sure if I can come up with a better way, I might take another look in the future because my life is also kinda busy at the moment.

Rosalie241 avatar Mar 14 '23 19:03 Rosalie241