appimage.github.io icon indicating copy to clipboard operation
appimage.github.io copied to clipboard

Add sunshine

Open ReenigneArcher opened this issue 3 years ago • 3 comments

This is WIP until the next release of Sunshine.

ReenigneArcher avatar May 06 '22 19:05 ReenigneArcher

Please don't do this:

https://github.com/SunshineStream/Sunshine/blob/4b658cd86ba0b7520f6f7cb5b5f07d6775845a81/.github/workflows/CI.yml#L117-L124

Instead, please add the files to the AppImage and copy them out of the AppImage when the application runs for the first time.

probonopd avatar May 07 '22 21:05 probonopd

Please don't do this:

https://github.com/SunshineStream/Sunshine/blob/4b658cd86ba0b7520f6f7cb5b5f07d6775845a81/.github/workflows/CI.yml#L117-L124

Instead, please add the files to the AppImage and copy them out of the AppImage when the application runs for the first time.

We're in process of rewriting all the packages including the AppImage: https://github.com/SunshineStream/Sunshine/blob/fff419a7ff19c11b029054181db35f578aced4f1/.github/workflows/CI.yml#L105

ReenigneArcher avatar May 08 '22 01:05 ReenigneArcher

Instead, please add the files to the AppImage and copy them out of the AppImage when the application runs for the first time.

@probonopd do you have any example? I'm struggling to find how to add non libraries to the AppImage? I am using linuxdeploy to create the AppImage.

ReenigneArcher avatar May 11 '22 23:05 ReenigneArcher

This is ready for review now. Thanks!

ReenigneArcher avatar Oct 31 '22 13:10 ReenigneArcher

P.S. this image is compiled on Ubuntu 20.04 and according to appimagelint, will not run on 18.04.

The image can be compiled on 18.04, but AppImage lint fails on 18.04 (due to an issue with the tar package included in the GitHub runner).

See this unresolved issue: https://github.com/TheAssassin/appimagelint/issues/28 As well as latest attempt here: https://github.com/LizardByte/Sunshine/actions/runs/3371164942/jobs/5593023238#step:8:756

GitHub is removing 18.04 runners in exactly one month though, so it will be very difficult for us to build on 18.04 even if we fix the issue with tar. https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/

ReenigneArcher avatar Nov 01 '22 20:11 ReenigneArcher

Thank you very much @ReenigneArcher

image

probonopd avatar Nov 02 '22 21:11 probonopd