appflowy-editor icon indicating copy to clipboard operation
appflowy-editor copied to clipboard

fix:replace_text

Open q200892907 opened this issue 9 months ago • 4 comments

fix https://github.com/AppFlowy-IO/AppFlowy/issues/5189

https://github.com/AppFlowy-IO/appflowy-editor/assets/4517301/b0e8b370-6503-4e6a-a474-439c686ac3f7

q200892907 avatar Apr 25 '24 06:04 q200892907

@q200892907 Your change is incorrect. It will cause the input text to lose its format.

LucasXu0 avatar Apr 26 '24 08:04 LucasXu0

@LucasXu0 I understand what it means. I will modify the code later and add a blacklist to handle the format.

q200892907 avatar Apr 26 '24 08:04 q200892907

 inlineAttributesBlacklist.addAll([
      InlineMathEquationKeys.formula,
    ]); 

Add blacklist to solve text input problem

https://github.com/AppFlowy-IO/appflowy-editor/assets/4517301/a0e1ef24-546d-450d-bc60-34c9bfdf9d81

q200892907 avatar Apr 26 '24 09:04 q200892907

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.74%. Comparing base (5d4f236) to head (17bee87). Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   75.32%   74.74%   -0.59%     
==========================================
  Files         300      300              
  Lines       14032    14162     +130     
==========================================
+ Hits        10570    10585      +15     
- Misses       3462     3577     +115     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 26 '24 09:04 codecov[bot]