appflowy-editor icon indicating copy to clipboard operation
appflowy-editor copied to clipboard

[FR] Make the Position Fixed at a place for Toolbar

Open dawarepramod4 opened this issue 1 year ago • 6 comments

Description

I want to use appflowy inside an already created list.. and also i want method so that instead of floating toolbar i want to have a toolbar which is stick to a place... or anywhere on the page ... (it should add height as i add new line... while inside another scrollview)

Impact

  1. Users who want to use the appflowy with their own widgets inside a list can use this featrure.

Additional Context

No response

dawarepramod4 avatar Mar 04 '24 20:03 dawarepramod4

We used to support shrinkWrapping, but after major refactoring of the selection handling, we broke the shrinkWrap.

Try to pass shrinkWrap: true to both the AppFlowyEditor and the EditorScrollController.

Edit: Seems I recalled wrongly, we do support shrinkWrap for editable mode as well, it just has degraded performance!


To shortly address your second issue, with a sticky toolbar, we could definitely add a simple API for this along with example usage.

Xazin avatar Mar 04 '24 21:03 Xazin

You can check this PR. https://github.com/AppFlowy-IO/appflowy-editor/pull/739

LucasXu0 avatar Mar 06 '24 02:03 LucasXu0

Thank you @LucasXu0 !

dawarepramod4 avatar Mar 06 '24 17:03 dawarepramod4

We used to support shrinkWrapping, but after major refactoring of the selection handling, we broke the shrinkWrap.

Try to pass shrinkWrap: true to both the AppFlowyEditor and the EditorScrollController.

Edit: Seems I recalled wrongly, we do support shrinkWrap for editable mode as well, it just has degraded performance!

To shortly address your second issue, with a sticky toolbar, we could definitely add a simple API for this along with example usage.

Thank you @Xazin. i will try this workaraound for shrinkwrapping in my code..!

dawarepramod4 avatar Mar 06 '24 17:03 dawarepramod4

Quite some refactor for a shrinkwrap to not work still

cyberpwnn avatar Jul 12 '24 10:07 cyberpwnn