Title Node Plugin For AppFlowy Editor
Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.
Comparison is base (
af8d96b) 80.41% compared to head (bfd2bfe) 80.84%.
:exclamation: Current head bfd2bfe differs from pull request most recent head 065c8aa. Consider uploading reports for the commit 065c8aa to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 80.41% 80.84% +0.42%
==========================================
Files 281 253 -28
Lines 11863 10331 -1532
==========================================
- Hits 9540 8352 -1188
+ Misses 2323 1979 -344
| Files | Coverage Δ | |
|---|---|---|
| ...nent/service/renderer/block_component_service.dart | 67.50% <100.00%> (-2.96%) |
:arrow_down: |
| lib/src/editor_state.dart | 84.45% <100.00%> (-0.16%) |
:arrow_down: |
| ...t/title_block_component/title_block_component.dart | 90.19% <90.19%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @LucasXu0 can you help take a look at this?
I'm not a fan of the implementation itself, maybe you have a better method in mind?
@LucasXu0
I see two issues still here, what is your take on them:
- I'm not a fan of the way we're currently enforcing the title block to always be the first node in a document, do you have some ideas for another route I could look at for improving this?
- Currently it's possible to select and add attributes to a title, I assume we should disallow this and only allow for plain text / UTF emojis. Since formatting as a list or quote, breaks the plugin.
Once we can merge this, I can continue work on AppFlowy to remove the title bar and abstract the share button and font settings out of the title bar as well.
@LucasXu0
I see two issues still here, what is your take on them:
- I'm not a fan of the way we're currently enforcing the title block to always be the first node in a document, do you have some ideas for another route I could look at for improving this?
- Currently it's possible to select and add attributes to a title, I assume we should disallow this and only allow for plain text / UTF emojis. Since formatting as a list or quote, breaks the plugin.
Once we can merge this, I can continue work on AppFlowy to remove the title bar and abstract the share button and font settings out of the title bar as well.
Will address the 2nd issue and then merge, to continue with the improvements on AppFlowy.