AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[FR] Add hover and selected state of Trash

Open vincentdchan opened this issue 3 years ago • 1 comments

When the Trash tab is selected, there is no hover state.

image

Expect:

Add hover and selected background of Trash corresponding to the item of the panel:

image

vincentdchan avatar Aug 12 '22 07:08 vincentdchan

Please assign this to me.

IMPranshu avatar Aug 22 '22 05:08 IMPranshu

I am interested in solving this issue. Can you assign me? @vincentdchan

rasyidmi avatar Nov 18 '22 05:11 rasyidmi

Hello @IMPranshu, have you made any progress on this? If not, @rasyidmi would like to take a crack at it

richardshiue avatar Nov 22 '22 04:11 richardshiue

Hello @richardshiue, I have written my code and the video of the result is here

Can you assign me so you can review it?

Thank you.

rasyidmi avatar Nov 25 '22 15:11 rasyidmi

This is the link for my commit

commit link

rasyidmi avatar Nov 25 '22 16:11 rasyidmi

Got it, thanks for working on this! I've assigned the issue to you

richardshiue avatar Nov 25 '22 16:11 richardshiue

Got it, thanks for working on this! I've assigned the issue to you

Thank you @richardshiue can't wait for the review😄

rasyidmi avatar Nov 25 '22 16:11 rasyidmi

With #1513 merged, this task is complete!

richardshiue avatar Jan 04 '23 06:01 richardshiue