AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[Bug] Language selector does not save language when reopening

Open sunny7dusk opened this issue 3 years ago • 5 comments

Describe the bug When using the language selector to use a language, UI changes to reflect it. However, if you close the app and reopen it, the language selector remains at the previously chosen language but the language of the UI returns to English.

To Reproduce Steps to reproduce the behavior:

  1. Go to settings through the settings icon on the top left, then pick the language option on the sidebar
  2. Pick any non-English language. You should see the UI updating the locale.
  3. Close and reopen the app.
  4. When the app reopens, you should see that the language has returned to English.
  5. Navigate to settings -> language again, you should see the language selector is at the language previously selected.

Expected behavior When choosing a new language, it should have saved the locale even after closing and opening a new session.

Screenshots This is when I reopen Flowly after changing language. image

Desktop (please complete the following information):

  • OS -> Windows 10 with WSL2

sunny7dusk avatar Jul 23 '22 17:07 sunny7dusk

@sunny7dusk would you like to work on this?

annieappflowy avatar Jul 26 '22 02:07 annieappflowy

I can take a look at this @annieappflowy

sunny7dusk avatar Jul 26 '22 03:07 sunny7dusk

Hi @sunny7dusk , any update on this? Do you need any help from me?

annieappflowy avatar Aug 26 '22 13:08 annieappflowy

@sunny7dusk , any update on this? If you no longer work on this issue, please let me know so I can release it to other contributors.

annieappflowy avatar Sep 13 '22 06:09 annieappflowy

Sorry about that, can look into this soon

sunny7dusk avatar Sep 13 '22 12:09 sunny7dusk

I have a PR up for this issue @annieappflowy

sunny7dusk avatar Sep 18 '22 18:09 sunny7dusk

@sunny7dusk , thank you. It is merged? Can you share the link?

Found it: https://github.com/AppFlowy-IO/AppFlowy/pull/1089

annieappflowy avatar Sep 20 '22 07:09 annieappflowy

Great work. Closing this issue.

annieappflowy avatar Sep 20 '22 07:09 annieappflowy