AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[FR] Icon color for light/dark mode

Open appflowy opened this issue 2 years ago • 3 comments

The icon seems weird on light mode, but it works on dart mode. The icon color should be pure dark in light mode and light gray in dark mode.

image

The color should not be const, it should read from the theme color. image

Not only the ViewDisclosureAction but also AppDisclosureAction has the same problem.

appflowy avatar Jul 23 '22 06:07 appflowy

Wouldn't it be better to have this in the theme instead? All icons need to be adjusted according to the current theme.

MikeWallaceDev avatar Jul 23 '22 14:07 MikeWallaceDev

I want to take up this issue. Please assign it to me.

IMPranshu avatar Aug 22 '22 05:08 IMPranshu

I want to take up this issue. Please assign it to me.

Alright! You could DM me if you have any questions.

appflowy avatar Aug 22 '22 06:08 appflowy

@annieappflowy I believe this has been implemented, should be good to close

richardshiue avatar Oct 23 '22 10:10 richardshiue