AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

chore: remove supabase dependency

Open Xazin opened this issue 1 year ago • 3 comments

Supabase has been sunsetted and is not being used in the client.

I've removed the code related to supabase (mostly from the Flutter side and in language files). - If we plan to add it back, it remains mostly untouched in the backend as of yet, although there is a lot of unused strategies and edge-cases that litter the authentication logic.

For backwards compatibility, I didn't remove the EncryptSecretScreen and surrounding logic.

PR Checklist

  • [x] My code adheres to AppFlowy's Conventions
  • [ ] I've listed at least one issue that this PR fixes in the description above.
  • [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • [x] All existing tests are passing.

Xazin avatar Sep 24 '24 17:09 Xazin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.26%. Comparing base (7ecf213) to head (596100f). Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6396      +/-   ##
==========================================
+ Coverage   74.41%   75.26%   +0.84%     
==========================================
  Files         245      232      -13     
  Lines        6566     6828     +262     
  Branches     1057      964      -93     
==========================================
+ Hits         4886     5139     +253     
+ Misses       1628     1626       -2     
- Partials       52       63      +11     
Flag Coverage Δ
appflowy_web_app 75.26% <ø> (+0.84%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 24 '24 18:09 codecov[bot]

There are some pub deps that can't be updated because of constraints set by the supabase_flutter version. Now, we can remove those dependency overrides in dependency_overrides.

LucasXu0 avatar Sep 25 '24 01:09 LucasXu0

There are some pub deps that can't be updated because of constraints set by the supabase_flutter version. Now, we can remove those dependency overrides in dependency_overrides.

I wasn't aware 👍 I will take a look.

Xazin avatar Sep 25 '24 06:09 Xazin