fix: row cover improvements
Requires: https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/294
- [x] Adjust size of the file upload menu in media cell
- [x] Fix issue where sometimes the upload menu for media wouldn't open
- [x] Use same style for Cover in Document on Row Detail Page
- [x] Show the row cover when opened in full page
- [x] Add ability to change cover after it is added, and adjust behavior so it's the same as the document cover. (Adding a cover will make it into the default asset cover)
- [x] Adjusted tests to the new changes
- [x] Set image from media cell as cover
- [x] Duplicate row meta when duplicating a row (eg. also bring cover, and other meta data in new row)
Feature Preview
TBD
PR Checklist
- [x] My code adheres to AppFlowy's Conventions
- [ ] I've listed at least one issue that this PR fixes in the description above.
- [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
- [x] All existing tests are passing.
🥷 Ninja i18n – 🛎️ Translations need to be updated
Project /project.inlang
| lint rule | new reports | level | link |
|---|---|---|---|
| Missing translation | 27 | warning | contribute (via Fink 🐦) |
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.26%. Comparing base (
7ecf213) to head (6291a58). Report is 34 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #6381 +/- ##
==========================================
+ Coverage 74.41% 75.26% +0.84%
==========================================
Files 245 232 -13
Lines 6566 6828 +262
Branches 1057 964 -93
==========================================
+ Hits 4886 5139 +253
+ Misses 1628 1626 -2
- Partials 52 63 +11
| Flag | Coverage Δ | |
|---|---|---|
| appflowy_web_app | 75.26% <ø> (+0.84%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Xazin When can I merge this PR?
@Xazin When can I merge this PR?
We need to merge https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/294 and update collab revision. Then we can run the tests and double check everything is working as it should.