AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

fix: 0.7.0 launch review issues

Open LucasXu0 opened this issue 1 year ago • 3 comments

Feature Preview

  • [x] cannot use 'move to' from sidebar
  • [x] show a forbiend cusor when moving a page to database
  • [x] check if the move to path is same as current path
  • [x] document width doesn't refresh after resetting
  • [x] disable tooltip when dragging blocks
  • [x] reminder not render when dragging
  • [x] after changing the language in the settings page, some of the text doesn't change
  • [x] support moving a block to another block's child
  • [x] fix assertion when dragging table
  • [ ] tests
    • [x] cannot use 'move to' from sidebar
    • [x] show a forbiend cusor when moving a page to database
    • [ ] check if the move to path is same as current path
    • [ ] document width doesn't refresh after resetting
    • [ ] disable tooltip when dragging blocks
    • [ ] reminder not render when dragging
    • [ ] after changing the language in the settings page, some of the text doesn't change
    • [ ] support moving a block to another block's child
    • [ ] fix assertion when dragging table

PR Checklist

  • [x] My code adheres to AppFlowy's Conventions
  • [ ] I've listed at least one issue that this PR fixes in the description above.
  • [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • [ ] All existing tests are passing.

LucasXu0 avatar Sep 20 '24 09:09 LucasXu0

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 54 warning contribute (via Fink 🐦)

github-actions[bot] avatar Sep 20 '24 09:09 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.25%. Comparing base (7ecf213) to head (5bcb9f2). Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6365      +/-   ##
==========================================
+ Coverage   74.41%   75.25%   +0.84%     
==========================================
  Files         245      233      -12     
  Lines        6566     6830     +264     
  Branches     1057      965      -92     
==========================================
+ Hits         4886     5140     +254     
+ Misses       1628     1627       -1     
- Partials       52       63      +11     
Flag Coverage Δ
appflowy_web_app 75.25% <ø> (+0.84%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 20 '24 09:09 codecov[bot]

Feature Preview

  • [x] cannot use 'move to' from sidebar
  • [x] show a forbiend cusor when moving a page to database
  • [x] check if the move to path is same as current path
  • [x] document width doesn't refresh after resetting
  • [x] disable tooltip when dragging blocks
  • [x] reminder not render when dragging
  • [x] after changing the language in the settings page, some of the text doesn't change
  • [x] support moving a block to another block's child
  • [x] fix assertion when dragging table
  • [ ] tests

Since you had fixed lots of bugs, can you make some tests for them?

appflowy avatar Sep 21 '24 07:09 appflowy

LGTM

appflowy avatar Sep 22 '24 01:09 appflowy