AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

feat: support adjusting document width

Open LucasXu0 opened this issue 1 year ago • 6 comments

Feature Preview

closes https://github.com/AppFlowy-IO/AppFlowy/issues/6312

update:

Screenshot 2024-09-17 at 15 47 06

https://github.com/user-attachments/assets/49d4f951-12ce-4833-9dff-c7804a1bd0ae


PR Checklist

  • [x] My code adheres to AppFlowy's Conventions
  • [x] I've listed at least one issue that this PR fixes in the description above.
  • [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • [ ] All existing tests are passing.

LucasXu0 avatar Sep 17 '24 02:09 LucasXu0

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 81 warning contribute (via Fink 🐦)

github-actions[bot] avatar Sep 17 '24 02:09 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.41%. Comparing base (7ecf213) to head (b9636cd). Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6327   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files         245      245           
  Lines        6566     6566           
  Branches     1057     1057           
=======================================
  Hits         4886     4886           
  Misses       1628     1628           
  Partials       52       52           
Flag Coverage Δ
appflowy_web_app 74.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 17 '24 02:09 codecov[bot]

I like this. It'll be much easier to follow the content on wide screens.

Is the last step in the slider for unlimited width?

Also I'm not sure if it would make sense to put the slider in the menu with font size, but you could easily see the width of the document as you resize.

emmggi avatar Sep 17 '24 10:09 emmggi

I like this. It'll be much easier to follow the content on wide screens.

Is the last step in the slider for unlimited width?

Also I'm not sure if it would make sense to put the slider in the menu with font size, but you could easily see the width of the document as you resize.

Added an image of the menu you speak of :+1:

image

I guess we could also add it there.

Xazin avatar Sep 17 '24 11:09 Xazin

@emmggi In the original implementation, I added the slider in the popup menu. However, I think it would make more sense to control the document width for all pages in settings, so I moved this slider to the settings page.

As you suggested, I'm going to add a slider to the document menu to allow users to customize the document width for a specific page. (This will be in the upcoming PR)

This way, we can control either all page widths globally or a single page width individually.

LucasXu0 avatar Sep 17 '24 13:09 LucasXu0

customize the document width for a specific page

Not sure how many users would benefit this but we'll see how it goes. :shrug:

Thanks.

emmggi avatar Sep 17 '24 18:09 emmggi