AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard
verified publisher icon AppFlowy-IO

fix: card rebuild issue

Open Xazin opened this issue 1 year ago • 2 comments

Feature Preview

Before:

https://github.com/user-attachments/assets/27c68517-94c5-41a9-a0af-5ec21ca236f3

PR Checklist

  • [ ] My code adheres to AppFlowy's Conventions
  • [ ] I've listed at least one issue that this PR fixes in the description above.
  • [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • [ ] All existing tests are passing.

Xazin avatar Sep 11 '24 10:09 Xazin

https://github.com/user-attachments/assets/b941d1ca-a308-4442-a5fa-c31bcfc08bcf

it still have issue when rebuilding card

appflowy avatar Sep 11 '24 13:09 appflowy

https://github.com/user-attachments/assets/b941d1ca-a308-4442-a5fa-c31bcfc08bcf

it still have issue when rebuilding card

It's a different bug. The one I fixed is a hover bug (see video).

We have a lack of separation of logic, everything goes through the BoardBloc. When the BoardBloc state changes (eg. Update group), a lot of components will rebuild as an effect.

Xazin avatar Sep 11 '24 13:09 Xazin