AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard
verified publisher icon AppFlowy-IO

feat: Kanban Clickable Links

Open SeanSiders opened this issue 1 year ago • 4 comments

Feature Preview

https://github.com/user-attachments/assets/59b491b9-142f-491a-9829-595d1531df76

closes https://github.com/AppFlowy-IO/AppFlowy/issues/5905

PR Checklist

  • [x] My code adheres to AppFlowy's Conventions
  • [x] I've listed at least one issue that this PR fixes in the description above.
  • [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • [x] All existing tests are passing.

SeanSiders avatar Aug 09 '24 21:08 SeanSiders

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 09 '24 21:08 CLAassistant

Should I write a test for this? I don't see any coverage for the related UI.

SeanSiders avatar Aug 13 '24 17:08 SeanSiders

Should I write a test for this? I don't see any coverage for the related UI.

I would never say no to a test or two haha, if you could write a simple integration test that would be great.

Xazin avatar Aug 13 '24 17:08 Xazin

Hey, I'm sorry about the delay. Since you haven't added tests, we will merge it as is if we can.

@LucasXu0 or I will take a look at this PR next week and make sure to make any changes we want and merge it :+1: (And add a test if we deem the need to)

Xazin avatar Sep 19 '24 18:09 Xazin