AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

feat: time field time type and time tracks

Open zoli opened this issue 1 year ago • 5 comments

Continuing on #4083 I added time type and precision for time field type. Now you can choose from edit property that the time type is "Plain Time", "Stopwatch" (count up), "Timer" (count down).

It's not completed yet tracking feature is missing plus some bug fixes. So I will make this a draft PR. Just wanted to add a preview here and maybe discuss some specifics.

IMO time field with tracking, count up, count down features along with some other features (i.e. calculating the total time of all rows) will help users to use AppFlowy as a To-do list with time tracking included.

Feature Preview

VID_20240716_213606_047.webm


PR Checklist

  • [x] My code adheres to AppFlowy's Conventions
  • [x] I've listed at least one issue that this PR fixes in the description above.
  • [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • [x] All existing tests are passing.

zoli avatar Jul 16 '24 18:07 zoli

IMO this will need a better design later.

zoli avatar Jul 16 '24 18:07 zoli

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 540 warning contribute (via Fink 🐦)

github-actions[bot] avatar Jul 18 '24 08:07 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.90%. Comparing base (c122f0a) to head (be7404d). Report is 763 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5747       +/-   ##
===========================================
- Coverage   86.74%   72.90%   -13.85%     
===========================================
  Files         217      240       +23     
  Lines        5032     6466     +1434     
  Branches      831     1042      +211     
===========================================
+ Hits         4365     4714      +349     
- Misses        561     1641     +1080     
- Partials      106      111        +5     
Flag Coverage Δ
appflowy_web_app 72.90% <ø> (-13.85%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 22 '24 17:07 codecov[bot]

Time tracking button preview:

https://github.com/user-attachments/assets/6bc64d97-641c-4663-a7d4-a41b21b5f3cc

zoli avatar Jul 22 '24 18:07 zoli

Currently, the mobile app will only view the time field final time in a text field. If the design, functionality, etc is OK, I will also add complete functionality for mobile in the next PRs.

zoli avatar Jul 22 '24 18:07 zoli