AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[Bug] Dark mode maybe a little too dark

Open apomalyn opened this issue 2 years ago • 6 comments

Describe the bug

There are someplace where the dark mode is a little too dark. 😄

Screenshots

The add button (+) is barely (or not at all) visible (fixed in 0.0.4.1) The add button (+) is barely (or not at all) visible
The inline code color is difficult to read

When dark mode is enabled the default color of the inline code is very complexe to read. The inline code color is difficult to read

Text highlighted not readeable When a text is highlight it should reverse is color to still be readable. This is only true on dark mode. Text highlighted not readeable
Text format toolbar (fixed in 0.0.4.1) Text format toolbar
Header (titles) are like 'muted' instead of promoted Header (titles) are like 'muted' instead of promoted

Desktop (please complete the following information):

  • OS: MacOS
  • Version 0.0.4.1

Additional context

If you wish to check the colour contrast compliance with a11y, I personally use these the webaim tool or colors.a11y tool

apomalyn avatar Apr 06 '22 21:04 apomalyn

@annieappflowy I updated the PR to match the remaining bugs. If possible, could you also add the 'bug' label (maybe add the design also)? 😄

apomalyn avatar Jun 28 '22 15:06 apomalyn

@apomalyn , thank you. I added the labels. I also granted you the permission to triage the issues. You should receive an invitation for this. Please also check this if you dont: https://github.com/AppFlowy-IO/AppFlowy/invitations Thanks a lot for helping us!

appflowy avatar Jul 03 '22 03:07 appflowy

Hi, additionally to this drop down also looks bad:

image

notstyle avatar Jul 20 '22 07:07 notstyle

@notstyle thanks for the feedback. I've labeled this issue as "needs design".

annieappflowy avatar Jul 20 '22 12:07 annieappflowy

Was told to comment on; even with the latest beta version it is still difficult to read highlights with Dark Mode UI

fangykai avatar Sep 06 '22 20:09 fangykai

I'm sourcing a designer to work on this

annieappflowy avatar Sep 07 '22 06:09 annieappflowy

(I'm adding this as a commend here as @apomalyn suggested).

Hello. First of all, thank you for making this incredibly promising application. I really hope this project takes off. We need a proper Notion alternative and this one seems really well done.

My problem is with the dark theme setup. When I use it, highlighted text becomes unreadable... 2022-09-14_12-06

My suggestion: make the highlighting colors "semi transparent" inside the program (like 50%). So if the user sets a green highlight, it looks like a light-green with the white background of the bright theme of the application, generating good contrast with the black text... and that same semi-transparent green, looks like dark-green with the black backdround of the dark theme, making good contrast with the white text.

Thank you in advance!

tuqueque avatar Sep 14 '22 18:09 tuqueque

Hello, annie... congratulations for this great project that is AppyFlow...I'm sure it will become one of the best options to other apps of its kind. For now I join those who suggest improving the readability of the text in the dark theme. Hopefully in the future you have an open color palette for the user to choose the color of your preference. And I think it will solve many improvement reports. Greetings!!!

Jmsi18 avatar Jan 24 '23 21:01 Jmsi18

I understand a designer is needed to fix this, I am adding this comment for completeness.

I am also having issues with poor contrast for the following items; Options in a "Select" property on a Board or Grid

Screenshot from 2023-01-26 15-34-17

Screenshot from 2023-01-26 15-41-28

Tooltip text Screenshot from 2023-01-26 15-33-52

Desktop: OS: Linux (Fedora 37 Gnome 43.2 Wayland) Version 1.0.0.1 (Flatpak)

Thank you for your amazing application and contribution!

brodiefairhall avatar Jan 26 '23 04:01 brodiefairhall

Upcoming v0.1.3 fixed this image image image

annieappflowy avatar Apr 19 '23 11:04 annieappflowy