AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[Bug] Cannot exit import window by pressing escape

Open PeterHero opened this issue 1 year ago • 4 comments

Bug Description

I like to close pop up windows by pressing escape. I would expect all windows to support this. I found that the import window does not support this. Not sure if it is a bug.

How to Reproduce

  1. Hover over a page in the left bar
  2. Click +
  3. Click import
  4. Windows opens up
  5. Pressing escape does nothing

Expected Behavior

The window is expected to close after pressing escape.

Operating System

Linux (arch)

AppFlowy Version(s)

0.3.9

Screenshots

No response

Additional Context

No response

PeterHero avatar Dec 30 '23 19:12 PeterHero

Hey! I am a first-time contributor here. If this is a Flutter issue, can this be assigned to me?

Smit56R avatar Jan 02 '24 13:01 Smit56R

Assigned. Thanks, @Smit56R , for offering the help.

annieappflowy avatar Jan 02 '24 19:01 annieappflowy

Hey @Smit56R, Are you still working on this?

ekakshjanweja avatar Feb 09 '24 20:02 ekakshjanweja

Hi @ekakshjanweja. My builds were failing so I have worked on the issue for a while. Sorry to not inform it sooner.

Smit56R avatar Feb 10 '24 02:02 Smit56R

Hey, is this issue still open? I just reproduced this issue, and I might know a way of solving it. Can I send a PR?

vkuasar0 avatar Apr 03 '24 22:04 vkuasar0

Feel free to send a PR @vkuasar0

annieappflowy avatar Apr 04 '24 01:04 annieappflowy

Hey, is this issue still open? I just reproduced this issue, and I might know a way of solving it. Can I send a PR?

Hey Vkuasar, you can follow other examples in our application, we use a Listener (Most of the time a KeyboardListener), to pop the dialog when Escape is pressed (remember to only check for KeyDownEvent's).

Xazin avatar Apr 04 '24 06:04 Xazin

Hey, I'm a first time contributor, so I'm a little confused. Do I have to add a video in the pull request description? PS: I used KeyboardListener, and also checked for KeyDownEvent

vkuasar0 avatar Apr 04 '24 11:04 vkuasar0

Hey, I'm a first time contributor, so I'm a little confused. Do I have to add a video in the pull request description? PS: I used KeyboardListener, and also checked for KeyDownEvent

It's not required to add a preview.

Xazin avatar Apr 04 '24 11:04 Xazin

Yep, done sending PR

vkuasar0 avatar Apr 04 '24 11:04 vkuasar0