AppFlowy
AppFlowy copied to clipboard
[Bug] Cannot exit import window by pressing escape
Bug Description
I like to close pop up windows by pressing escape. I would expect all windows to support this. I found that the import window does not support this. Not sure if it is a bug.
How to Reproduce
- Hover over a page in the left bar
- Click +
- Click import
- Windows opens up
- Pressing escape does nothing
Expected Behavior
The window is expected to close after pressing escape.
Operating System
Linux (arch)
AppFlowy Version(s)
0.3.9
Screenshots
No response
Additional Context
No response
Hey! I am a first-time contributor here. If this is a Flutter issue, can this be assigned to me?
Assigned. Thanks, @Smit56R , for offering the help.
Hey @Smit56R, Are you still working on this?
Hi @ekakshjanweja. My builds were failing so I have worked on the issue for a while. Sorry to not inform it sooner.
Hey, is this issue still open? I just reproduced this issue, and I might know a way of solving it. Can I send a PR?
Feel free to send a PR @vkuasar0
Hey, is this issue still open? I just reproduced this issue, and I might know a way of solving it. Can I send a PR?
Hey Vkuasar, you can follow other examples in our application, we use a Listener (Most of the time a KeyboardListener), to pop the dialog when Escape is pressed (remember to only check for KeyDownEvent's).
Hey, I'm a first time contributor, so I'm a little confused. Do I have to add a video in the pull request description? PS: I used KeyboardListener, and also checked for KeyDownEvent
Hey, I'm a first time contributor, so I'm a little confused. Do I have to add a video in the pull request description? PS: I used KeyboardListener, and also checked for KeyDownEvent
It's not required to add a preview.
Yep, done sending PR