AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

feat: emoji shortcut feature

Open Tony-MK opened this issue 1 year ago • 3 comments

Feature Preview


Closes: https://github.com/AppFlowy-IO/AppFlowy/issues/2797

PR Checklist

  • [X] My code adheres to AppFlowy's Conventions
  • [X] I've listed at least one issue that this PR fixes in the description above.
  • [X] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • [X] All existing tests are passing.

Tony-MK avatar Dec 06 '23 22:12 Tony-MK

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 06 '23 22:12 CLAassistant

@Xazin, Can you spare some time to review this PR? If you are too busy I could ask @LucasXu0 if he has some time. Also, kindly help me with feedback if my PR is sufficient. Thank you 😄

Tony-MK avatar Dec 14 '23 20:12 Tony-MK

I'll have to test something before leaving a final approval, I'll see if I can get to it this weekend, sorry for the wait.

Xazin avatar Feb 16 '24 17:02 Xazin

@Tony-MK @LucasXu0

The _selectEmoji method fails to insert the emoji and delete the search text.

It seems to be due to something wrong with the composition that happens with applying the insert of the emoji.

// Replace text with actual emoji
await widget.editorState.apply(
  widget.editorState.transaction
    ..replaceText(
      node,
      (selection.end.offset - _emojiController.text.length - 1)
          .clamp(0, selection.end.offset),
      selection.end.offset,
      searchEmojiList[_selectedIndex].emoji,
    ),
);

We can't merge before this is resolved.

Xazin avatar Jun 09 '24 19:06 Xazin

Working on it...

Tony-MK avatar Jun 10 '24 08:06 Tony-MK

Pending for two months. Closing this PR for now.

annieappflowy avatar Aug 12 '24 03:08 annieappflowy