AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[FR] Support inserting caption in image block

Open LucasXu0 opened this issue 2 years ago • 7 comments

Description

  • Support inserting caption in image block

For example,

Screenshot 2023-09-20 at 22 28 16

Impact

for the user who need to insert caption under the image block

Additional Context

No response

LucasXu0 avatar Sep 20 '23 14:09 LucasXu0

Hello Lucas, I would like to work on this

RawatDevanshu avatar Sep 27 '23 12:09 RawatDevanshu

@LucasXu0 can you assign me issue i want to work on it

cherish2003 avatar Oct 03 '23 15:10 cherish2003

Would you like to take it @RawatDevanshu ? Otherwise, I'll assign this to @cherish2003

annieappflowy avatar Oct 04 '23 12:10 annieappflowy

yes I will be working on this issue as soon as you assign.

RawatDevanshu avatar Oct 04 '23 13:10 RawatDevanshu

Assigned to @RawatDevanshu

annieappflowy avatar Oct 04 '23 13:10 annieappflowy

@cherish2003 , have you found any other issues that interest you?

annieappflowy avatar Oct 04 '23 13:10 annieappflowy

hello @LucasXu0, I have implemented the required change and it looks visually as asked but it is not functionally working can you share some insights on what can work, I have tried moving the text field widget up the tree but it's not working, after selecting text field and pressing backspace the whole image block gets deleted.

I have added gif example here:- https://pasteboard.co/MnqpivItCKSi.gif

so basically keyboard controls are not working as usual for textfield widget

this is how it looks right now:- image image

Here are the changes i made to line 119 in custom_image_block_component.dart child = BlockSelectionContainer( node: node, delegate: this, listenable: editorState.selectionNotifier, blockColor: editorState.editorStyle.selectionColor, supportTypes: const [ BlockSelectionType.block, ], child: Padding( key: imageKey, padding: padding, child: Column( children: [ child, const Padding( padding: EdgeInsets.symmetric(horizontal: 10.0), child: TextField( style: TextStyle(decoration: TextDecoration.underline), decoration: InputDecoration( border: InputBorder.none, hintText: 'Caption', hintStyle: TextStyle(decoration: TextDecoration.underline), ), ), ), ], ), ), );

RawatDevanshu avatar Oct 22 '23 07:10 RawatDevanshu

Supported in v0.10.5

annieappflowy avatar Dec 05 '25 04:12 annieappflowy