AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[Bug] Add missing Tabs hotkeys to Shortcut settings

Open Xazin opened this issue 2 years ago • 10 comments
trafficstars

Bug Description

Inside appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart exists some hotkeys that are not included in the shortcut settings, and thus are not customizable.

These include some for tabs:

  • Close current tab
  • Go to next tab
  • Go to previous tab

Additionally there are some other hotkeys that should also be added:

  • Collapse sidebar menu
  • Toggle theme mode

How to Reproduce

  1. Open AppFlowy
  2. Open Settings
  3. Navigate to Shortcuts
  4. Cannot change eg. "Navigate to next tab" as it doesn't exist in the list

Expected Behavior

  1. Open AppFlowy
  2. Open Settings
  3. Navigate to Shortcuts
  4. Can change the shortcut for "Navigate to next tab"

Operating System

All

AppFlowy Version(s)

0.3.1

Screenshots

No response

Additional Context

No response

Xazin avatar Sep 13 '23 09:09 Xazin

Hi @Xazin I want to contribute to this change please assign it to me and please provide some more context to which hotkeys changes need to be done. Thanks in advance.

lavanyayangala avatar Oct 01 '23 19:10 lavanyayangala

Hi @Xazin I want to contribute to this change please assign it to me and please provide some more context to which hotkeys changes need to be done.

Thanks in advance.

Hey, I have assigned you, feel free to reach out to us if you need help or have questions!

Xazin avatar Oct 01 '23 19:10 Xazin

Hi @Xazin I want to contribute to this change please assign it to me and please provide some more context to which hotkeys changes need to be done. Thanks in advance.

Hey, I have assigned you, feel free to reach out to us if you need help or have questions!

@Xazin Thankyou for assigning can i get some more context and any resources to proceed .

lavanyayangala avatar Oct 02 '23 09:10 lavanyayangala

Hi @Xazin I want to contribute to this change please assign it to me and please provide some more context to which hotkeys changes need to be done. Thanks in advance.

Hey, I have assigned you, feel free to reach out to us if you need help or have questions!

@Xazin Thankyou for assigning can i get some more context and any resources to proceed .

The hotkeys that exist in the file listed in the issue description, cannot be changed in Settings -> Shortcuts.

This is a screenshot of Settings -> Shortcuts

image

Eventually, check out ShortcutsCubit and ShortcutsListView.

Xazin avatar Oct 02 '23 09:10 Xazin

Hey @Xazin thanks for the timely response. I am quite overwhelmed in regards to setup for changes in my local laptop for windows can I get information in short context. As I am a new bee in Flutter and open source contributions.

lavanyayangala avatar Oct 02 '23 09:10 lavanyayangala

@annieappflowy I would like to work on this issue if it's still not being worked on!

Trapiz avatar Mar 25 '24 08:03 Trapiz

@annieappflowy I would like to work on this issue if it's still not being worked on!

Hey @Trapiz feel free to open a PR, let me know if you need any guidance, for easier back and forth you can ask in our Discord 👍

Xazin avatar Mar 25 '24 10:03 Xazin

@annieappflowy I would like to work on this issue if it's still not being worked on!

Hey @Trapiz feel free to open a PR, let me know if you need any guidance, for easier back and forth you can ask in our Discord 👍

Cool thanks! I will start looking into this and will ask for some pointers in the Discord if I need them!

Trapiz avatar Mar 25 '24 15:03 Trapiz

@annieappflowy I would like to work on this issue

Chefkj avatar Aug 06 '24 21:08 Chefkj

Hi @Xazin !! can i work on this issue if it's still not being worked on. I'm new in this opensource world but i'm quite familiar with flutter and firebase and i was looking for some good challenges to test my skills.

maiHydrogen avatar Oct 25 '24 10:10 maiHydrogen

I've been following this issue, and it seems that the missing shortcuts are related to the TabsBloc.

gustamor avatar Feb 28 '25 13:02 gustamor