AppFlowy
AppFlowy copied to clipboard
[Bug] Add missing Tabs hotkeys to Shortcut settings
Bug Description
Inside appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart exists some hotkeys that are not included in the shortcut settings, and thus are not customizable.
These include some for tabs:
- Close current tab
- Go to next tab
- Go to previous tab
Additionally there are some other hotkeys that should also be added:
- Collapse sidebar menu
- Toggle theme mode
How to Reproduce
- Open AppFlowy
- Open Settings
- Navigate to Shortcuts
- Cannot change eg. "Navigate to next tab" as it doesn't exist in the list
Expected Behavior
- Open AppFlowy
- Open Settings
- Navigate to Shortcuts
- Can change the shortcut for "Navigate to next tab"
Operating System
All
AppFlowy Version(s)
0.3.1
Screenshots
No response
Additional Context
No response
Hi @Xazin I want to contribute to this change please assign it to me and please provide some more context to which hotkeys changes need to be done. Thanks in advance.
Hi @Xazin I want to contribute to this change please assign it to me and please provide some more context to which hotkeys changes need to be done.
Thanks in advance.
Hey, I have assigned you, feel free to reach out to us if you need help or have questions!
Hi @Xazin I want to contribute to this change please assign it to me and please provide some more context to which hotkeys changes need to be done. Thanks in advance.
Hey, I have assigned you, feel free to reach out to us if you need help or have questions!
@Xazin Thankyou for assigning can i get some more context and any resources to proceed .
Hi @Xazin I want to contribute to this change please assign it to me and please provide some more context to which hotkeys changes need to be done. Thanks in advance.
Hey, I have assigned you, feel free to reach out to us if you need help or have questions!
@Xazin Thankyou for assigning can i get some more context and any resources to proceed .
The hotkeys that exist in the file listed in the issue description, cannot be changed in Settings -> Shortcuts.
This is a screenshot of Settings -> Shortcuts
Eventually, check out ShortcutsCubit and ShortcutsListView.
Hey @Xazin thanks for the timely response. I am quite overwhelmed in regards to setup for changes in my local laptop for windows can I get information in short context. As I am a new bee in Flutter and open source contributions.
@annieappflowy I would like to work on this issue if it's still not being worked on!
@annieappflowy I would like to work on this issue if it's still not being worked on!
Hey @Trapiz feel free to open a PR, let me know if you need any guidance, for easier back and forth you can ask in our Discord 👍
@annieappflowy I would like to work on this issue if it's still not being worked on!
Hey @Trapiz feel free to open a PR, let me know if you need any guidance, for easier back and forth you can ask in our Discord 👍
Cool thanks! I will start looking into this and will ask for some pointers in the Discord if I need them!
@annieappflowy I would like to work on this issue
Hi @Xazin !! can i work on this issue if it's still not being worked on. I'm new in this opensource world but i'm quite familiar with flutter and firebase and i was looking for some good challenges to test my skills.
I've been following this issue, and it seems that the missing shortcuts are related to the TabsBloc.