feat: open apps in tabs
Closes: #2942 Relates: #2312
Feature Preview
https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/c070cf3f-5187-4ea9-84cf-5eddfe689146
PR Checklist
- [x] My code adheres to the AppFlowy Style Guide
- [x] I've listed at least one issue that this PR fixes in the description above.
- [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
- [x] All existing tests are passing.
Codecov Report
Merging #2962 (23917ff) into main (0dae8cf) will decrease coverage by
0.29%. The diff coverage is43.96%.
@@ Coverage Diff @@
## main #2962 +/- ##
==========================================
- Coverage 67.71% 67.42% -0.29%
==========================================
Files 417 422 +5
Lines 19866 20055 +189
==========================================
+ Hits 13452 13523 +71
- Misses 6414 6532 +118
| Flag | Coverage Δ | |
|---|---|---|
| appflowy_flutter_integrateion_test | 65.13% <43.96%> (-0.27%) |
:arrow_down: |
| appflowy_flutter_unit_test | 12.40% <0.43%> (-0.12%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...tend/appflowy_flutter/lib/plugins/blank/blank.dart | 84.61% <0.00%> (-7.06%) |
:arrow_down: |
| ...ib/plugins/database_view/tar_bar/tab_bar_view.dart | 93.82% <0.00%> (-1.18%) |
:arrow_down: |
| ...ppflowy_flutter/lib/plugins/document/document.dart | 86.36% <0.00%> (-4.12%) |
:arrow_down: |
| ...tion/editor_plugins/base/built_in_page_widget.dart | 63.41% <0.00%> (-1.59%) |
:arrow_down: |
| ...ntend/appflowy_flutter/lib/plugins/trash/menu.dart | 78.26% <0.00%> (-3.56%) |
:arrow_down: |
| ...tend/appflowy_flutter/lib/plugins/trash/trash.dart | 10.00% <0.00%> (-1.12%) |
:arrow_down: |
| ...ter/lib/workspace/presentation/home/menu/menu.dart | 84.76% <0.00%> (-0.82%) |
:arrow_down: |
| ...ib/workspace/presentation/home/tabs/flowy_tab.dart | 0.00% <0.00%> (ø) |
|
| ...b/workspace/presentation/widgets/tab_bar_item.dart | 0.00% <0.00%> (ø) |
|
| ...space/presentation/home/menu/app/section/item.dart | 92.22% <37.50%> (-5.34%) |
:arrow_down: |
| ... and 8 more |
@LucasXu0 I found one issue, and I'm not sure what is the best way to handle it.
When the SelectionMenu overlay is present, you can still change the tab, and it doesn't close. This is less than ideal.
What do you believe to be the best approach to forcefully close it?
@Xazin Let me see. I need to check out your branch to take a look.
Once again thank you for implementing this. In what version can we expect this?
Once again thank you for implementing this. In what version can we expect this?
Hey Emmgii, this will be in our next release (0.2.7).
I might be doing a few tweaks to the behavior so that the UX will be more smooth, I expect the refinements to be in 0.2.8.
One important thing to do is to restore tabs that were open prior to closing the app.
One important thing to do is to restore tabs that were open prior to closing the app.
Good catch