AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

fix: use same base width for all screen sizes

Open richardshiue opened this issue 1 year ago • 1 comments

resolves #2637

Title says all. I personally think that this is fine since we already set a minimum width on the window size.

However, if there are usability problems, please do let me know and I'll find another solution

Feature Preview


PR Checklist

  • [x] My code adheres to the AppFlowy Style Guide
  • [x] I've listed at least one issue that this PR fixes in the description above.
  • [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • [ ] All existing tests are passing.

richardshiue avatar Jul 10 '23 08:07 richardshiue

Codecov Report

Merging #2961 (f037f73) into main (ff9b3c5) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2961      +/-   ##
==========================================
- Coverage   67.70%   67.69%   -0.01%     
==========================================
  Files         417      417              
  Lines       19859    19857       -2     
==========================================
- Hits        13446    13443       -3     
- Misses       6413     6414       +1     
Flag Coverage Δ
appflowy_flutter_integrateion_test 65.37% <100.00%> (+0.04%) :arrow_up:
appflowy_flutter_unit_test 12.52% <0.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/lib/workspace/presentation/home/home_layout.dart 92.85% <100.00%> (+5.35%) :arrow_up:

... and 1 file with indirect coverage changes

codecov[bot] avatar Jul 10 '23 09:07 codecov[bot]