AppFlowy
AppFlowy copied to clipboard
feat: enable sort by date + sort fix
The logic for date sorting is already there. This PR primarily addreses the problem of empty cells being included in the sort. They should now be placed at the very bottom
TODO: fix regression: checkbox field not being sorted properly. The cell data is initially empty when created so it's automatically moved to the bottom, which isn't the desired behavior when the sort is Ascending (edit: done)
TODO: fix multi-sort logic (edit: done)
Feature Preview
resolves #2775
PR Checklist
- [x] My code adheres to the AppFlowy Style Guide
- [x] I've listed at least one issue that this PR fixes in the description above.
- [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
- [ ] All existing tests are passing.
Codecov Report
Merging #2953 (fec7122) into main (b1378b4) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #2953 +/- ##
=======================================
Coverage 68.77% 68.77%
=======================================
Files 430 430
Lines 20469 20470 +1
=======================================
+ Hits 14078 14079 +1
Misses 6391 6391
Flag | Coverage Δ | |
---|---|---|
appflowy_flutter_integrateion_test | 65.73% <100.00%> (+<0.01%) |
:arrow_up: |
appflowy_flutter_unit_test | 13.13% <0.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...abase_view/application/field/field_controller.dart | 83.00% <100.00%> (+0.04%) |
:arrow_up: |
I think we should add some tests to validate these cases where the cell is empty.
/usr/bin/ld: final link failed: No space left on device
Ignore this error temporarily.