AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard
verified publisher icon AppFlowy-IO

[Bug] The animation of scrolling to heading is too slowly when using outline

Open LucasXu0 opened this issue 2 years ago • 3 comments

Bug Description

As the title said, the animation is too slowly now.

  • Just remove the animation is fine.

How to Reproduce

  1. insert some headings.
  2. insert an outline block.
  3. click the content inside the outline.

Expected Behavior

Scroll the position of heading directly without any animation.

Operating System

all platform.

AppFlowy Version(s)

0.2.5

Screenshots

No response

Additional Context

No response

LucasXu0 avatar Jul 07 '23 10:07 LucasXu0

This slow scrolling also happens when your cursor leaves the screen by scrolling and then start typing. The animation is very slow to bring you back to the cursor. I thought these were purposely implemented.

emmggi avatar Jul 07 '23 19:07 emmggi

@LucasXu0 I would like to fix this issue with the Outline.

AmanNegi avatar Jul 10 '23 03:07 AmanNegi

@AmanNegi Do you have any ideas now? Feel free to share them here, and we can discuss them together.

LucasXu0 avatar Jul 10 '23 10:07 LucasXu0

Hi @LucasXu0 does it meet the requirements? I sped up the animation so the user doesn't feel too slow

https://github.com/AppFlowy-IO/AppFlowy/assets/22239637/5f729a63-e2f3-4ec8-9573-f35bbace2b2a

johansutrisno avatar Jul 18 '23 22:07 johansutrisno

Hi @LucasXu0 does it meet the requirements? I sped up the animation so the user doesn't feel too slow

Screen.Recording.2023-07-19.at.05.08.21.mov

I suggest removing the animation in this case. If you have any ideas, feel free to DM me(Lucas@AppFlowy) on Discord.

LucasXu0 avatar Jul 19 '23 02:07 LucasXu0

I also believe we should remove the animation for the best UX.

Xazin avatar Jul 19 '23 10:07 Xazin

Yes in a long document this type of scrolling would not be a good experience. If possible we can add a curve to the animation like easeInOut. So that it feels more natural to the user.

AmanNegi avatar Jul 19 '23 13:07 AmanNegi

I see, is it better than before? cc @LucasXu0 @Xazin @AmanNegi

https://github.com/AppFlowy-IO/AppFlowy/assets/22239637/278290f2-ba38-494f-b9cf-b5d2dd3eeefd

johansutrisno avatar Jul 21 '23 16:07 johansutrisno

I see, is it better than before?

cc @LucasXu0 @Xazin @AmanNegi

https://github.com/AppFlowy-IO/AppFlowy/assets/22239637/278290f2-ba38-494f-b9cf-b5d2dd3eeefd

Yeah, best for now. 🙏

Xazin avatar Jul 21 '23 18:07 Xazin

okay I will create the PR ASAP 🙏🏻

johansutrisno avatar Jul 22 '23 18:07 johansutrisno

I have created the PR for appflowy repo and appflowy-editor repo, please review the PR, thank you in advance

  • https://github.com/AppFlowy-IO/AppFlowy/pull/3045
  • https://github.com/AppFlowy-IO/appflowy-editor/pull/337

johansutrisno avatar Jul 22 '23 20:07 johansutrisno