AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

fix: correcting mistmatched json_serializable version

Open donlaiq opened this issue 1 year ago • 4 comments

I saw a few warnings in the installation process, and with these changes I think I'm fixing two of them:

[WARNING] json_serializable on lib/env_serde.dart: The version constraint "^4.7.0" on json_annotation allows versions before 4.8.1 which is not allowed.

[WARNING] json_serializable on lib/colorscheme/colorscheme.dart: The version constraint "^4.7.0" on json_annotation allows versions before 4.8.1 which is not allowed.

Hopefully, if everything goes well, and it's accepted, I'll try to fix the other ones.

donlaiq avatar Jul 06 '23 03:07 donlaiq

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 06 '23 03:07 CLAassistant

Codecov Report

Merging #2944 (42886f9) into main (edc7933) will increase coverage by 56.21%. The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2944       +/-   ##
===========================================
+ Coverage   12.56%   68.77%   +56.21%     
===========================================
  Files         415      430       +15     
  Lines       19760    20469      +709     
===========================================
+ Hits         2483    14078    +11595     
+ Misses      17277     6391    -10886     
Flag Coverage Δ
appflowy_flutter_integrateion_test 65.72% <ø> (?)
appflowy_flutter_unit_test 13.13% <ø> (+0.56%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 349 files with indirect coverage changes

codecov[bot] avatar Jul 06 '23 05:07 codecov[bot]

Is there a way to run those test locally before to make the pull request? I've undone my changes and run the following command (the one failing in https://github.com/AppFlowy-IO/AppFlowy/actions/runs/5471271334/jobs/9963233326?pr=2944) from the frontend/rust-lib folder:

RUST_LOG=info RUST_BACKTRACE=1 cargo test --no-default-features --features="rev-sqlite"

But anyway, some tests are not passing. Maybe, it's because I'm running it from Linux Debian?

donlaiq avatar Jul 06 '23 14:07 donlaiq

@donlaiq It's not related to your PR. I'm fixing the CI issues now.

LucasXu0 avatar Jul 07 '23 12:07 LucasXu0

Hey @donlaiq, the changes in this PR seem irrelevant to the title. Can we close this, or will you be working on it?

Feel free to jump into our discord if you have any questions.

Xazin avatar Jul 14 '23 09:07 Xazin

Hello @Xazin, the PR removes 2 warnings in the installation process (attached images). So, actually it does what the title says, and I also explained it in my first comment. After that, I did some changes to remove other warnings, but I didn't know that it will mix with this current PR, so I revert it. Feel free to close it if you think it's irrelevant.

w1 w2

donlaiq avatar Jul 14 '23 12:07 donlaiq

Hello @Xazin, the PR removes 2 warnings in the installation process (attached images). So, actually it does what the title says, and I also explained it in my first comment. After that, I did some changes to remove other warnings, but I didn't know that it will mix with this current PR, so I revert it. Feel free to close it if you think it's irrelevant.

w1 w2

There are no changes related to pubspec.yaml in the current diff. Seems you accidentally removed it, thus my previous comment.

Xazin avatar Jul 14 '23 12:07 Xazin

Oh, I'm sorry about that @Xazin. It seems I messed it up with the revert.

donlaiq avatar Jul 14 '23 13:07 donlaiq

By the way @Xazin, it seems this PR solve also the following kind of warnings during the installation process. Hopefully, you can accept the changes, because I think I found the way of solving the next group of warnings, but I don't want to keep mixing the things up on this thread. w3

donlaiq avatar Jul 14 '23 20:07 donlaiq

@donlaiq I close this PR. Please feel to reopen

appflowy avatar Sep 01 '23 15:09 appflowy