AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[FR] Search v0.1

Open annieappflowy opened this issue 2 years ago • 17 comments

Description

Allow users to search in the workspace using natural language queries A Search button can be found on the left panel It can also be triggered via a shortcut cmd/ctrl + P

When you open the search window, you'll see a list of pages under Recent Pages. These are all pages from your workspace that you've visited lately.

Show the previous search query under Recent Searches in the search window.

Impact

All users who retrieve information through searching with keywords or asking questions

Additional Context

No response

annieappflowy avatar Apr 11 '23 02:04 annieappflowy

May I ask why this FR is delayed to v0.2.6?

sudo-saif avatar May 14 '23 23:05 sudo-saif

May I ask why this FR is delayed to v0.2.6?

It's complex to implement, and it is made up of multiple parts that need to come together. Backend design & implementation, UIUX design, and Frontend implementation.

I think v0.2.6 is the goal, but for this to actually be worth it to implement, there are other features that should be prioritized first.

Xazin avatar May 15 '23 00:05 Xazin

Why Ctrl-P? Isn't that the shortcut for printing a hard-copy by convention almost on all applications and all platforms?

akaihola avatar Jun 10 '23 07:06 akaihola

So what's the most common shortcut for triggering the search command?

annieappflowy avatar Jun 10 '23 07:06 annieappflowy

CTRL+K is the most common command for opening up a Command Palette, it's also the most common command for inserting a link if an editor is focused.

CTRL+F is the most common command for document search.

CTRL+Shift+F is the most common command for full workspace search.

Xazin avatar Jun 10 '23 11:06 Xazin

I think we can implement the search function with the following steps:

  1. Search the document by keyword.
  2. Search the database by keyword.
  3. Search for the document in the database row by keyword.

Let’s start with step 1. I am not sure if the document content search can be a plugin or not. This plugin could index the document and provide the indexing data to be saved on disk. It would allow third-party developers to index the document if they need to. In AppFlowy, we can store the indexing data in the backend.

appflowy avatar Jul 10 '23 13:07 appflowy

Currently, I am working on a Find and Replace handler in the editor (this feature allows users to search within a document), I am using Ctrl+F and Ctrl+H for them. So we should use Ctrl+Shift+F for implementing this feature.

MayurSMahajan avatar Jul 10 '23 15:07 MayurSMahajan

Currently, I am working on a Find and Replace handler in the editor (this feature allows users to search within a document), I am using Ctrl+F and Ctrl+H for them. So we should use Ctrl+Shift+F for implementing this feature.

Can you hit me up on discord about this. We might need to consider some things when implementing the built-in document search for the editor.

Xazin avatar Jul 10 '23 17:07 Xazin

delay again...

Mojicode avatar Sep 12 '23 00:09 Mojicode

There's a lot of moving parts that need to come together. Eventually it will come through

rileyhawk1417 avatar Oct 24 '23 17:10 rileyhawk1417

waiting

lmk0724 avatar Nov 08 '23 10:11 lmk0724

It's a important feature. I think, without this AppFlowy cannot use with many notes.

mauxdev avatar Nov 11 '23 13:11 mauxdev

Thanks a lot to the team. the lack of this function is this only reason why i still use notion ...

SimDav888 avatar Dec 06 '23 02:12 SimDav888

@SimDav888 +1, can't believe that such an extremely important feature is not implemented yet, I wonder how appflowy team prioritize their development efforts.

sudo-saif avatar Dec 06 '23 03:12 sudo-saif

@SimDav888 +1, can't believe that such an extremely important feature is not implemented yet, I wonder how appflowy team prioritize their development efforts.

Come on... dev is hard. I can imagine they had other priorities. For instance, the app looks very good and has a ios and android version. It s already a great achievement. All dev thanks you for the good work please don t give up on us little users

SimDav888 avatar Dec 06 '23 03:12 SimDav888

I just installed appflowy a few minutes ago and thought it was cool until I tried to search for something. Search is basic expected functionality for notes and such. TBH, I was shocked it's not here yet.

Please consider adding this basic functionality ASAP.

louisjg avatar Dec 06 '23 10:12 louisjg

Just installed this app a few minutes ago like louisjg says. I created a few notes and wanted to search but the functionality is missing. Can't replace notion without this basic feature

FlorinZai avatar Dec 07 '23 21:12 FlorinZai

Can't use AppFlowy currenly without this feature. I write many notes... and navigate between I would add also CTRL + P like in VSCode which let you open file by title

thewh1teagle avatar Jan 11 '24 13:01 thewh1teagle

Hey, just wanted to highlight the priority of this feature. The ability to search through the notes is my main blocker to migrate from iOS/Mac notes.... The search needs to be robust and ideally should be integrated with Mac/iOS search.

mkrzych avatar Feb 18 '24 13:02 mkrzych