AppFlowy icon indicating copy to clipboard operation
AppFlowy copied to clipboard

[FR] Handle invalid URLs when formatting text as a link

Open annieappflowy opened this issue 2 years ago • 12 comments

Description

On the link edition/creation dialog you can type anything and it's still accepted, it should only accept URL (from web URL to system (I don't know how they are called) URL like mailto, call, etc.)

In the link editing menu, we should let the user know "Type a valid URL to link"

Impact

Users who format text as links

Additional Context

No response

annieappflowy avatar Apr 05 '23 09:04 annieappflowy

I would like to work on this issue.

GouravShDev avatar Apr 05 '23 10:04 GouravShDev

@GouravShDev would you let me work on this issue?

rwt-2001 avatar Apr 05 '23 11:04 rwt-2001

@rwt-2001 sure.

GouravShDev avatar Apr 05 '23 11:04 GouravShDev

Thanks @GouravShDev. I think there are other interesting issues to take :D Assigned it to @rwt-2001

annieappflowy avatar Apr 05 '23 14:04 annieappflowy

The PR linked to this does not change any behavior inside the link menu, are we sure this is completed?

Xazin avatar Apr 23 '23 10:04 Xazin

@annieappflowy @Xazin, if no one working on this, can I take it up? :smiley:

Chandan-CV avatar May 24 '23 05:05 Chandan-CV

@annieappflowy Can you assign me this issue?

Chandan-CV avatar May 31 '23 04:05 Chandan-CV

Sorry for the late response. Are you still keen to work on it? @Chandan-CV

annieappflowy avatar Jul 11 '23 13:07 annieappflowy

Hi @annieappflowy , can i work on this? Also what all changes are required? Like should i change the title from 'Add your link' to 'Type a valid URL to link' and change the functionality by first checking if the link is valid before clicking entering or either of the two? Thank you! Screenshot 2023-07-16 at 3 13 13 PM

AdiAr11 avatar Jul 16 '23 09:07 AdiAr11

Hi @AdiAr11 , are you available to work on this?

annieappflowy avatar Aug 11 '23 05:08 annieappflowy

@annieappflowy Yes, I am available!

AdiAr11 avatar Aug 11 '23 05:08 AdiAr11

@annieappflowy I think the following PR fixes this issue. https://github.com/AppFlowy-IO/appflowy-editor/pull/324

AdiAr11 avatar Sep 28 '23 14:09 AdiAr11