appdaemon icon indicating copy to clipboard operation
appdaemon copied to clipboard

Async/non-async http endpoints receive the same args

Open esev opened this issue 1 year ago • 1 comments

112a0337c410a60ca2df926a97eae7eebb4a9bc0 removed the http request object from the async http endpoint callback signature. In my use-case, the request object is needed to access the client IP address. The request object was added back in ece502d257c1a53110c0837a6819eafeab3c11d3 for non-async callbacks. This PR adds access to the request object for both async and non-async calls.

I've also updated the documentation to reflect the changes from ece502d257c1a53110c0837a6819eafeab3c11d3.

Fixes #1818

esev avatar Sep 24 '23 17:09 esev

+1 I just spent half a day after AppDaemon upgrade from 4.2 trying to figure out why my app doesn't work. I use it as a websocket server.

pmarki avatar Oct 17 '23 10:10 pmarki