appdaemon
appdaemon copied to clipboard
Provide a weather widget that defaults to pirateweather
Is there an existing feature request for this?
- [X] I have searched the existing issues
Your feature request
The pirateweather integration provides sensors that are nearly identical to dark sky. Now that dark sky is not freely available, implementations of the weather widget require explicit overrides of all entities. A pirateweather widget could be identical to the weather widget but default to the pirateweather sensors.
I have code and documentation changes ready for a pull request.
I'd be happy to accept a PR for this - thanks.
The documentation (DASHBOARD_CREATION.rst) passes the pre-commit trailing whitespace test but fails it on commit. Is there a trick?
No trick I am aware of - which part is failing, creation of the PR?
Just trying to commit to my branch of dev.On Jun 23, 2023 05:51, Andrew Cockburn @.***> wrote: No trick I am aware of - which part is failing, creation of the PR?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
Your IDE should give you a log message as to which part of pre-commit is failing, do you have that output?
From: Dave Dixon @.> Sent: Friday, June 23, 2023 10:00 AM To: AppDaemon/appdaemon @.> Cc: Andrew Cockburn @.>; Comment @.> Subject: Re: [AppDaemon/appdaemon] Provide a weather widget that defaults to pirateweather (Issue #1826)
Just trying to commit to my branch of dev.On Jun 23, 2023 05:51, Andrew Cockburn @.***> wrote: No trick I am aware of - which part is failing, creation of the PR?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
— Reply to this email directly, view it on GitHubhttps://github.com/AppDaemon/appdaemon/issues/1826#issuecomment-1604327432, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACLE7JH6JZDO23CXGIOMZ3LXMWOP5ANCNFSM6AAAAAAZNOGD5I. You are receiving this because you commented.Message ID: @.***>
User error - it was failing on "trim trailing whitespace" but the actual error was a warning - "Unstaged files detected." I remedied that and the commit succeeded - almost. I can't git push because my personal access token has expired so I have to refamiliarize myself with that process. Hopefully won't take too long.
Okay, I think I did the PR right.