apollo-contrib icon indicating copy to clipboard operation
apollo-contrib copied to clipboard

pandora: sync code with the latest version of https://github.com/HesaiTechnology/Pandora_ros

Open FlorentRevest opened this issue 5 years ago • 0 comments

I couldn't use the Pandora's cameras with the driver currently provided by apollo-contrib. I simply copied the latest version of each file in the Pandora_ros driver provided by HesaiTechnology and got the cameras working. For now, this PR contains a simple copy of the code of HesaiTechnology. However, I noticed it introduces some regressions (such as typos which had been fixed by Baidu, like deconstructor/destructor) Should I just let those typos in to make it easier in the future to sync the driver with the code of HesaiTechnology? Should I fix them all and only keep code changes? If you want changes from the code distributed by HESAI, then what else would you want?

FlorentRevest avatar Apr 18 '19 13:04 FlorentRevest