FluentModbus icon indicating copy to clipboard operation
FluentModbus copied to clipboard

Published 20 hours ago • verified publisher icon Apollo3zehn

Make use of BinaryPrimitives

Open Apollo3zehn opened this issue 2 years ago • 2 comments

https://github.com/dotnet/corefx/pull/24400

Apollo3zehn avatar Sep 21 '21 09:09 Apollo3zehn

I've tried to implement this, but there was issue where there's no switch from endianness on span/memory, just on primitive types. So, we might have to remove switching endianness on span/memory or leave it as is

https://github.com/Apollo3zehn/FluentModbus/blob/39d819d7258fbaa48f73966b1a06e25a042361af/src/FluentModbus/ModbusUtils.cs#L161-L178

aviatrix avatar Sep 27 '21 10:09 aviatrix

That's good to know, thanks :-) I'll leave this issue open as a reminder to completely review the server/client API to work with different byte layouts.

Apollo3zehn avatar Sep 30 '21 19:09 Apollo3zehn