apicurio-registry icon indicating copy to clipboard operation
apicurio-registry copied to clipboard

Published 20 hours ago • verified publisher icon Apicurio

feat: skip disabled artifact versions when looking for latest

Open jsenko opened this issue 2 years ago • 2 comments

Fixes #2790

jsenko avatar Oct 03 '22 15:10 jsenko

@EricWittmann @carlesarnal WDYT about this change? It slightly changes the behavior of some REST API paths, so I think I need to at least add a feature flag. Should the feature flag be enabled by default?

jsenko avatar Oct 04 '22 17:10 jsenko

Should be disabled by default I think. To preserve compatibility.

EricWittmann avatar Oct 06 '22 13:10 EricWittmann

@jsenko there are conflicts now with this PR, do you mind solving them?

carlesarnal avatar Nov 18 '22 09:11 carlesarnal

right, that's the plan when I'm back

jsenko avatar Nov 18 '22 09:11 jsenko

@jsenko I recommend rebasing main, the test failure is due to a flaky test and has been addressed on main.

carlesarnal avatar Nov 25 '22 19:11 carlesarnal

@jsenko I'm closing this PR for now. Whenever you have the bandwidth to come back to it, just re-open it.

carlesarnal avatar Mar 17 '23 16:03 carlesarnal

@carlesarnal @EricWittmann This PR is ready for merge, can you guys give it a quick look? Please ignore the javadoc stuff, but this should avoid the warnings.

jsenko avatar Apr 05 '23 11:04 jsenko