rules_ros icon indicating copy to clipboard operation
rules_ros copied to clipboard

Lists not parsed correctly by `repos_lock.update` on repos_index file

Open michael-sbarra-apexai opened this issue 1 year ago • 2 comments

For example:

  repo_name:
    version: XXX
    sha256: XXX
    strip_prefix: "repo_name-XXX"
    registry_type: repository
    project_id: XXX
    filename: archive.tar.gz
    type: apex_http_archive
    bazel: {}
    patches: ["//some.patch"]
    patch_args: ["-p1"]

Should be parsed as

    _maybe(
        name = "repo_name",
        version = "XXX",
        sha256 = "XXX",
        strip_prefix = "repo_name-XXX,
        registry_type = "repository",
        project_id = "XXX",
        filename = "archive.tar.gz",
        patches = ["some.patch"],
        patch_args = ["-p1"],
        repo_rule = apex_http_archive,
    )

But the lists are turned into a single string:

_maybe(
    name = "repo_name",
    version = "XXX",
    sha256 = "XXX",
    strip_prefix = "repo_name-XXX",
    registry_type = "repository",
    project_id = "XXX",
    filename = "archive.tar.gz",
    patches = "['some.patch']",
    patch_args = "['-p1']",
    repo_rule = apex_http_archive,
)

When calling bazel run @rules_ros//repos/config:repos_lock.update

michael-sbarra-apexai avatar Oct 03 '24 22:10 michael-sbarra-apexai

FYI @evan-flynn-apexai

michael-sbarra-apexai avatar Oct 03 '24 22:10 michael-sbarra-apexai

Thanks @michael-sbarra-apexai! I am unsure when I will have time to work on this. Since you discovered it, you probably already know where to fix it, so contributions are very welcome :)

bluka4 avatar Oct 04 '24 12:10 bluka4