py-solc-x icon indicating copy to clipboard operation
py-solc-x copied to clipboard

update solc_wrapper to expect return value of 0 from 'help' if solc >= v0.8.10

Open pacrob opened this issue 2 years ago • 2 comments

What I did

Starting with solc v0.8.10, running solc --help gives a return value of 0. It was previously 1. I added version checking to expect the correct value.

How I did it

I checked if the solc version being used was < v0.8.10 and set the expected return value accordingly.

How to verify it

Run the tests

Checklist

  • [ ] I have confirmed that my PR passes all linting checks
  • [x] I have included test cases
  • [ ] I have updated the documentation (README.md)
  • [ ] I have added an entry to the changelog

pacrob avatar Jan 07 '22 00:01 pacrob

Lint wouldn't work even on master, but I matched the surrounding code style. pre-commit threw mypy errors on code I didn't touch - I'd fix it if I knew how, but it's out of scope for this fix.

It doesn't seem appropriate for docs or changelog, but I'm happy to do so if you'd like.

pacrob avatar Jan 07 '22 00:01 pacrob

Great job. Why is this pull request still in pending since 6 months ?

philogicae avatar Jun 27 '22 12:06 philogicae

thank you, this was also causing problems for me

antazoey avatar Nov 09 '23 15:11 antazoey

btw im fixing all lint, tests, and type stuff on another branch. we are cleaning this package up and getting it updated because it has been causing lots of issues, such as this one.

antazoey avatar Nov 09 '23 15:11 antazoey