evm-trace icon indicating copy to clipboard operation
evm-trace copied to clipboard

Published 20 hours ago • verified publisher icon ApeWorX

Add Address type

Open NotPeopling2day opened this issue 2 years ago • 2 comments

Overview

While working on gas reporting, @fubuloubu mentioned wishing address type was more optimized. The original thought is to use an Address(HexBytes) class.

Specification

A little research is needed to see how well this fits with trace/gas reporting.

Dependencies

APE-58

NotPeopling2day avatar Sep 02 '22 01:09 NotPeopling2day

would be even nicer if it was just the same type that ape core uses, so conversion wasn't necessary

fubuloubu avatar Sep 02 '22 12:09 fubuloubu

@antazoey Should we use https://github.com/ApeWorX/eth-pydantic-types?tab=readme-ov-file#address for the address type issue? Or do you think we're okay how we're currently using address with eth_pydantic_types HexBytes?

NotPeopling2day avatar Jun 04 '24 01:06 NotPeopling2day