ape icon indicating copy to clipboard operation
ape copied to clipboard

Published 20 hours ago • verified publisher icon ApeWorX

fix: None check in SharedBlobReceipt

Open fp-crypto opened this issue 10 months ago • 2 comments

What I did

fixes: added a None check to hex_to_int in SharedBlobReceipt

How I did it

added a simple None check with a 0 return

How to verify it

Try hitting RPCs (such as tenderly's) that have not updated their returns post-Dencun.

Checklist

  • [ ] All changes are completed
  • [ ] New test cases have been added
  • [ ] Documentation has been updated

fp-crypto avatar Mar 28 '24 16:03 fp-crypto

although @banteg noted that this actually might be a legitimate value for it to have per EC spec

fubuloubu avatar Mar 28 '24 18:03 fubuloubu

have to use is for None check

so is this the case? we can adjust to allow None values

antazoey avatar Apr 04 '24 14:04 antazoey

re-open if still a problem or create an issue?

antazoey avatar May 01 '24 19:05 antazoey