anyl-wallet
anyl-wallet copied to clipboard
Get rid of Magic number in the code
At the moment, we are using a lot of magic numbers in the code. I would recommend that we start using Macro defines for these magic numbers. This would increase the readability and maintainability of the code.
Can you provide link to the files in which the magic numbers do occur?
There are many examples but here are few to mention:
- address.c -- keccak_256(pubkey+1, 64, hash); -- memcpy(addr_out, hash+12, 20);
- sign.c -- function: eth_sign -- signature[64] = pby + 27;