Mindustry
Mindustry copied to clipboard
Rules dialog changes
- New banned blocks/units dialog (other people asked me to PR this from my mod, so... i think no one will argue?)
- Rule info buttons are now displayed again on mobile devices
- Other elements in rules dialog like
number()
andnumberi()
now try to display rule info too. There's only checks that have info texts in vanilla right now, but this change is useful for mods
Info buttons (Vars.mobile = true
):
New dialog (with somewhat responsive behavior):
P.S: this dialog can be opened in portrait mode when editing rules in
MapPlayDialog
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:
- [x] I have read the contribution guidelines.
- [x] I have ensured that my code compiles, if applicable.
- [x] I have ensured that any new features in this PR function correctly in-game, if applicable.
What is your mod?
This dialog is a slightly changed version of Mapping Utilities' (new version) ban dialog https://github.com/ApsZoldat/MindustryMappingUtilities
The mod itself is not my proudest... thing to be honest But this dialog should be ok, at least you can now add multiple items without content table just disappearing (instead of rebuilding)
if it ain't merged, put it back in your mod to wait
New dialog is ported FROM my mod, what do you mean? If you're about the info buttons, well, it's just... not a big deal, huh?
what about the planets filter in the banned blocks dialog?
It doesn't work well with units, because there's no actual way to get unit type's planet except checking its production cost IIRC (which just doesn't work in all cases and is a shenanigan)
Maybe it's TODO for me, but more like shelved
@ApsZoldat maybe reference the tech tree?
this actually good pr gets forgotten