Mindustry icon indicating copy to clipboard operation
Mindustry copied to clipboard

Rules dialog changes

Open ApsZoldat opened this issue 9 months ago • 8 comments

  1. New banned blocks/units dialog (other people asked me to PR this from my mod, so... i think no one will argue?)
  2. Rule info buttons are now displayed again on mobile devices
  3. Other elements in rules dialog like number() and numberi() now try to display rule info too. There's only checks that have info texts in vanilla right now, but this change is useful for mods

Info buttons (Vars.mobile = true):

1

New dialog (with somewhat responsive behavior):

2 3 P.S: this dialog can be opened in portrait mode when editing rules in MapPlayDialog

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • [x] I have read the contribution guidelines.
  • [x] I have ensured that my code compiles, if applicable.
  • [x] I have ensured that any new features in this PR function correctly in-game, if applicable.

ApsZoldat avatar Apr 28 '24 16:04 ApsZoldat

What is your mod?

S0meM avatar Apr 29 '24 13:04 S0meM

This dialog is a slightly changed version of Mapping Utilities' (new version) ban dialog https://github.com/ApsZoldat/MindustryMappingUtilities

The mod itself is not my proudest... thing to be honest But this dialog should be ok, at least you can now add multiple items without content table just disappearing (instead of rebuilding)

ApsZoldat avatar Apr 29 '24 13:04 ApsZoldat

if it ain't merged, put it back in your mod to wait

BlueTheCube avatar May 10 '24 12:05 BlueTheCube

New dialog is ported FROM my mod, what do you mean? If you're about the info buttons, well, it's just... not a big deal, huh?

ApsZoldat avatar May 10 '24 13:05 ApsZoldat

what about the planets filter in the banned blocks dialog?

BlueTheCube avatar May 11 '24 04:05 BlueTheCube

It doesn't work well with units, because there's no actual way to get unit type's planet except checking its production cost IIRC (which just doesn't work in all cases and is a shenanigan)

Maybe it's TODO for me, but more like shelved

ApsZoldat avatar May 11 '24 08:05 ApsZoldat

@ApsZoldat maybe reference the tech tree?

BlueTheCube avatar Jun 23 '24 06:06 BlueTheCube

this actually good pr gets forgotten

BlueTheCube avatar Jul 21 '24 06:07 BlueTheCube