Mindustry icon indicating copy to clipboard operation
Mindustry copied to clipboard

ChatMode & history bugfix

Open Agzam4 opened this issue 1 year ago • 8 comments

Videos:

Before: before.zip After: after.zip


PS: Github highlighted the file as changed entirely, so I'll just say that I changed: Changed sendMessage() method

  • [X] I have read the contribution guidelines.
  • [X] I have ensured that my code compiles, if applicable.
  • [X] I have ensured that any new features in this PR function correctly in-game, if applicable.

Agzam4 avatar May 26 '23 21:05 Agzam4

It looks like you reformatted the file; you need to format it back to what it was before for me to review this properly.

Anuken avatar May 26 '23 21:05 Anuken

It looks like you reformatted the file; you need to format it back to what it was before for me to review this properly.

Ready

Agzam4 avatar May 26 '23 22:05 Agzam4

May be use String.startsWith. Sometime I like delete /t manually, then substring would be wrong.

way-zer avatar Jun 12 '23 01:06 way-zer

May be use String.startsWith. Sometime I like delete /t manually, then substring would be wrong.

If you mean deleting "\t" (for example using backspace), then everything works fine Video.zip

Agzam4 avatar Jun 12 '23 08:06 Agzam4

May be use String.startsWith. Sometime I like delete /t manually, then substring would be wrong.

If you mean deleting "\t" (for example using backspace), then everything works fine Video.zip

Delete, then write something?

way-zer avatar Jun 12 '23 09:06 way-zer

Delete, then write something? In the video, I press tab, thereby turn on "\t" mode, and then erase "\t", saving the text

Agzam4 avatar Jun 12 '23 09:06 Agzam4

In /t mode, delete /t manually, then write something. You will get wrong saved text.(wrong substring)

way-zer avatar Jun 12 '23 09:06 way-zer

In /t mode, delete /t manually, then write something. You will get wrong saved text.(wrong substring)

Thank you very much, while I was fixing this bug, I found another one in which pressing up and down created "\t", it seems now I have managed to make the story completely independent of the chat mod

Agzam4 avatar Jun 12 '23 13:06 Agzam4