Mindustry icon indicating copy to clipboard operation
Mindustry copied to clipboard

BetterPlanetSelection

Open stabu-dev opened this issue 1 year ago • 2 comments

Better looking UI for planet selection:

  • Buttons are now also colored in the color of the planet icon

  • If the modification has its own star system, then the planet selection buttons belonging to this system will be placed in a separate category with the name of the star that is the center of the system.

Demonstration:

Without modifications that have their own star systems: java_0yWdsh9m8r

With modifications that have their own star systems: java_S4x8dL1fiM Modifications used: FOS, Omaloon

  • [x] I have read the contribution guidelines.
  • [x] I have ensured that my code compiles, if applicable.
  • [x] I have ensured that any new features in this PR function correctly in-game, if applicable.

stabu-dev avatar Apr 09 '23 11:04 stabu-dev

@Anuken ?

stabu-dev avatar Apr 16 '23 13:04 stabu-dev

@Anuken Is there anything that still doesn't meet your requirements? Do I need to redo something?

stabu-dev avatar May 08 '23 06:05 stabu-dev

Formatting is still wrong, you still have spaces around braces. You also removed the spaces around = for some reason (the guidelines don't tell you to do this)

Anuken avatar May 08 '23 14:05 Anuken

Is everything correct now?

stabu-dev avatar May 09 '23 13:05 stabu-dev

...Now the indentation is broken, look at the diff. It's all on the left.

Anuken avatar May 09 '23 13:05 Anuken

...Now the indentation is broken, look at the diff. It's all on the left.

well @Anuken merge?

stabu-dev avatar May 09 '23 14:05 stabu-dev

You reformatted a bunch of unrelated stuff in the whole file now.

Anuken avatar May 09 '23 14:05 Anuken

Something strange with Github, I'll recreate pull request

stabu-dev avatar May 09 '23 15:05 stabu-dev