Mindustry icon indicating copy to clipboard operation
Mindustry copied to clipboard

Improved Power Generator Explosions

Open MEEPofFaith opened this issue 1 month ago • 4 comments

Better implementation of #11328.

  • Added shake (already a feature, but was unused).
  • Added scorch effect
  • Added fire
    • Should I use fireball projectiles instead?

https://github.com/user-attachments/assets/81a24c5b-8f46-4f90-bd3d-8b8ee0e72426

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • [x] I have read the contribution guidelines.
  • [x] I have ensured that my code compiles, if applicable.
  • [x] I have ensured that any new features in this PR function correctly in-game, if applicable.

MEEPofFaith avatar Nov 04 '25 20:11 MEEPofFaith

(constructFinish with a null unit is safe, right?)

MEEPofFaith avatar Nov 04 '25 20:11 MEEPofFaith

What if modder doesnt want it to break their props 🤔 probably just add canBreakProps or something to that breakable check.

JasonP01 avatar Nov 04 '25 23:11 JasonP01

I think it would look a lot better if the fireballs were projectiles, as then it would fit in with the 'outward radial explosion' effect that the Th reactor already has, and the other generators would look good with. And um… this is a lot better than mine.

alstocras avatar Nov 05 '25 14:11 alstocras

Projectiles could increase lag during the explosion. Not sure its necessary to begin with

JasonP01 avatar Nov 05 '25 14:11 JasonP01