Mindustry icon indicating copy to clipboard operation
Mindustry copied to clipboard

Optimize server list UX

Open ankando opened this issue 7 months ago • 4 comments

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • [x] I have read the contribution guidelines.
  • [x] I have ensured that my code compiles, if applicable.
  • [x] I have ensured that any new features in this PR function correctly in-game, if applicable.

ankando avatar Jun 03 '25 18:06 ankando

449981664-ee3a2fbb-314f-4e11-8771-e064cfaf3935

ghost avatar Jun 03 '25 18:06 ghost

Optimizations:

  1. Wait for the list to load before displaying it, and sort it by delay to reduce the randomness of the server location
  2. Add loading text animation

ghost avatar Jun 03 '25 18:06 ghost

你的代码我在一份已经关闭的pr内见到过并完全一致,你有什么头绪吗ity I've seen your code in a closed pr and it's exactly the same. Do you have any clues?

AWA-SUBARU-Deisu avatar Jun 05 '25 14:06 AWA-SUBARU-Deisu

"Optimize" is a bit misleading as it's ambiguous and can easily refer to performance.

For clarity, I'd recommend changing the PR title to something along the lines of "Add a reload spinner to the community server list."

Looking at this PR on the surface-level, it doesn't seem like it does anything related to "optimizing" (other than optimizing the UX -- so you could also potentially change the title to "Optimize server list UX").

BnDLett avatar Jun 06 '25 10:06 BnDLett

@Anuken I hope you will take a look at this PR. It would be best if you add a text animation and display it in the order of ping size after it is fully loaded, and then stop loading each time until you click the search button. There is another problem now. When the network is not good, the server location may be misplaced. For example, the server of this server group runs to another server group. I have found it many times but it cannot be directly reproduced.

anialic avatar Jul 22 '25 12:07 anialic